-
-
Notifications
You must be signed in to change notification settings - Fork 482
feat: make attachment downloading chunkable #2956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hzhreal
wants to merge
20
commits into
Pycord-Development:master
Choose a base branch
from
hzhreal:feat/attachment-chunking
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: make attachment downloading chunkable #2956
hzhreal
wants to merge
20
commits into
Pycord-Development:master
from
hzhreal:feat/attachment-chunking
+91
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/2956/head:pr-2956
git checkout pr-2956This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/2956/head |
|
Test code: import discord
import os
import aiofiles
from discord.ext import commands
bot = commands.Bot()
CHUNKSIZE = 1024 * 1024
@bot.slash_command()
async def download(ctx: discord.ApplicationContext, f: discord.Attachment) -> None:
size = f.size
written = 0
progress = "{}/{}"
await ctx.respond(progress.format(written, size))
async with aiofiles.open("test1.bin", "wb") as out:
async for chunk in f.read_chunked(chunksize=CHUNKSIZE):
await out.write(chunk)
chunksize = len(chunk)
written += chunksize
await ctx.edit(content=progress.format(written, size))
await f.save("test2.bin", chunksize=chunksize)
bot.run(os.getenv("TOKEN")) |
|
@hzhreal Could you please fix the merge conflicts ? Thx |
Signed-off-by: hzhreal <[email protected]>
Lulalaby
previously approved these changes
Oct 20, 2025
Signed-off-by: Paillat <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Paillat <[email protected]>
Signed-off-by: Lala Sabathil <[email protected]>
plun1331
previously requested changes
Oct 21, 2025
Signed-off-by: Lala Sabathil <[email protected]>
Co-authored-by: plun1331 <[email protected]> Signed-off-by: hzhreal <[email protected]>
auto-merge was automatically disabled
October 22, 2025 10:56
Head branch was pushed to by a user without write access
Co-authored-by: plun1331 <[email protected]> Signed-off-by: hzhreal <[email protected]>
Lulalaby
reviewed
Oct 22, 2025
Signed-off-by: Lala Sabathil <[email protected]>
Lulalaby
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
hold: testing
This pull request requires further testing
PA: All Contributors pending
priority: low
Low Priority
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The point of this PR is to offer an option for developers to download attachments in chunks instead of processing the whole file in memory at once to reduce possible overhead.
Changes:
HTTPClient.get_from_cdn_streamthat yields data in chunksAttachment.read_chunkedto process data in chunksAttachment.savegiving the option to write data to a file in chunks through an optional parameterInformation
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.