-
-
Notifications
You must be signed in to change notification settings - Fork 480
feat: ✨ Allow for functools.partial and functions returning an awaitable as autocomplete
#2669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ Allow for functools.partial and functions returning an awaitable as autocomplete
#2669
Conversation
functools.partials and such as autocompletefunctools.partials and such as autocomplete
|
@DefiDebauchery Would you mind testing this pr with your usecase and |
Yes, this did work on my side, thank you! While I also like the solution offered in #2668 (comment), I do think partials make sense in many contexts, and it would be great to have support for those who need something quick. |
3382447 to
142215d
Compare
142215d to
53036a4
Compare
functools.partials and such as autocompletefunctools.partials functions returning an awaitable as autocomplete
functools.partials functions returning an awaitable as autocompletefunctools.partial functions returning an awaitable as autocomplete
functools.partial functions returning an awaitable as autocompletefunctools.partial and functions returning an awaitable as autocomplete
|
Oh shoot checks failing... This is why we should be using |
Signed-off-by: Paillat <[email protected]>
Signed-off-by: Paillat <[email protected]>
Signed-off-by: Paillat <[email protected]>
|
Merge conflicts |
Signed-off-by: Paillat <[email protected]>
|
Fixed |
b55c125 to
82659b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge conflicts
|
tbh I might as well give up this one and make it part of the options rewrite in next |
|
idk. we dunno when next comes out. i'd prefer if we still have it here |
|
It's just that I don't really like that code I wrote but at the same time it's mainly because options are spaghetti code |
|
This breaks autocomplete, please hold |
Summary
Allows usage of functions with any number of optional parameters as autocomplete. This allows by extent the usage of partials and similar as autocomplete.
Fixes #2668
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.