fix: 🐛 Fix duplicate bridge cmds in default help cmd #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lulalaby
previously approved these changes
Nov 27, 2024
|
Please don't merge this yet I thought of something I want to test first. |
|
Ok I fixed a small issue there. |
|
In any case, the code for this help command is reeeally messed up ngl |
Dorukyum
reviewed
Dec 26, 2024
| @@ -550,7 +551,9 @@ def subcommand_not_found(self, command, string): | |||
| ) | |||
| return f'Command "{command.qualified_name}" has no subcommands.' | |||
|
|
|||
| async def filter_commands(self, commands, *, sort=False, key=None): | |||
| async def filter_commands( | |||
| self, commands, *, sort=False, key=None, exclude: tuple[Any] | None = None | |||
There was a problem hiding this comment.
Unpack not possible with sets
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2306
Closes: #2415
Alternative to: #2415 (stale imo)
If you prefer waiting for #2415 I don't mind, just made a quick fix here because that pr seemed dead.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.