feat: add missing with_counts parameter to fetch_guilds method #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Side note 1: Blame my IDE for "fixing" spaces in other funcs in the files I edited. |
plun1331
changed the title
plun1331
reviewed
Oct 21, 2024
plun1331
added
priority: low
Dorukyum
requested changes
Oct 21, 2024
Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Dark <[email protected]>
Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Dark <[email protected]>
|
Done |
plun1331
previously approved these changes
Oct 21, 2024
JustaSqu1d
suggested changes
Oct 25, 2024
Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: Dark <[email protected]>
auto-merge was automatically disabled
October 25, 2024 22:15
Head branch was pushed to by a user without write access
Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: Dark <[email protected]>
|
Squid and his grammar. |
plun1331
approved these changes
Oct 27, 2024
Dorukyum
approved these changes
Nov 3, 2024
plun1331
previously approved these changes
Nov 3, 2024
plun1331
approved these changes
Nov 3, 2024
OmLanke
pushed a commit
to OmLanke/pycord
that referenced
this pull request
Dec 16, 2024
…d-Development#2615) * refactor: Add missing `with_counts` parameter to guild retrieval methods * Default with_counts to True in fetch_guilds * Being dumb enough to forget about making it an int * style(pre-commit): auto fixes from pre-commit.com hooks * Update discord/client.py Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Dark <[email protected]> * Update discord/iterators.py Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Dark <[email protected]> * Update CHANGELOG.md * Update discord/client.py Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: Dark <[email protected]> * Update discord/iterators.py Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: Dark <[email protected]> --------- Signed-off-by: Dark <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dorukyum <[email protected]> Co-authored-by: JustaSqu1d <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
with_countsfor thefetch_guildsmethod, which was missing.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.