-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: category cooldown commands works in dms like other guild cooldowns #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revnoplex
changed the title
fix: category cooldown works in dms like other guild cooldowns
fix: category cooldown commands works in dms like other guild cooldowns
Oct 9, 2024
Dorukyum
reviewed
Oct 9, 2024
Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Revnoplex <[email protected]>
Dorukyum
requested changes
Oct 9, 2024
Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Revnoplex <[email protected]>
Signed-off-by: Revnoplex <[email protected]>
Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Revnoplex <[email protected]>
no, wait it undid it, actually it merged it weirdly |
Signed-off-by: Revnoplex <[email protected]>
Signed-off-by: Dorukyum <[email protected]>
Dorukyum
approved these changes
Oct 10, 2024
Lulalaby
approved these changes
Oct 10, 2024
baribarton
pushed a commit
to baribarton/pycord-no-potential-reconnect
that referenced
this pull request
Oct 24, 2024
…ns (Pycord-Development#2603) * fix: category cooldown works in dms like other guild cooldowns * style(pre-commit): auto fixes from pre-commit.com hooks * Add changelog entry * style(pre-commit): auto fixes from pre-commit.com hooks * Update discord/ext/commands/cooldowns.py Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Revnoplex <[email protected]> * Update discord/ext/commands/cooldowns.py Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Revnoplex <[email protected]> * fix mistyped suggestion cooldowns.py Signed-off-by: Revnoplex <[email protected]> * Update discord/ext/commands/cooldowns.py Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Revnoplex <[email protected]> * undo broken merge caused by b25d9a7 Signed-off-by: Revnoplex <[email protected]> * Update CHANGELOG.md Signed-off-by: Dorukyum <[email protected]> --------- Signed-off-by: Revnoplex <[email protected]> Signed-off-by: Dorukyum <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dorukyum <[email protected]>
OmLanke
pushed a commit
to OmLanke/pycord
that referenced
this pull request
Dec 16, 2024
…ns (Pycord-Development#2603) * fix: category cooldown works in dms like other guild cooldowns * style(pre-commit): auto fixes from pre-commit.com hooks * Add changelog entry * style(pre-commit): auto fixes from pre-commit.com hooks * Update discord/ext/commands/cooldowns.py Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Revnoplex <[email protected]> * Update discord/ext/commands/cooldowns.py Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Revnoplex <[email protected]> * fix mistyped suggestion cooldowns.py Signed-off-by: Revnoplex <[email protected]> * Update discord/ext/commands/cooldowns.py Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Revnoplex <[email protected]> * undo broken merge caused by b25d9a7 Signed-off-by: Revnoplex <[email protected]> * Update CHANGELOG.md Signed-off-by: Dorukyum <[email protected]> --------- Signed-off-by: Revnoplex <[email protected]> Signed-off-by: Dorukyum <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dorukyum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While testing certain cooldown types for my cooldown handler. I stumbled upon an error when using a command that had a category cooldown in DMs. Note that the other guild-like cooldown types such as
BucketType.guild
,BucketType.member
andBucketType.role
work fine in DMs. So it is reasonable to consider this an unintended error rather than intentional and should be fixed. The error was caused by returning the bucket id using(msg.channel.category or msg.channel).id
which can result in an error when it tries to access thecategory
attribute when the channel is not aGuildChannel
such as aPrivateChannel
which doesn't have acategory
attribute so it results in aAttributeError
. By using(msg.channel.category if isinstance(msg.channel, discord.abc.GuildChannel) else msg.channel).id
(aGuildChannel
always has a category attribute), it won't try to access the attribute when it can't.Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.