-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't try to do an interaction_check if there isn't a user available to check #2594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dorukyum
reviewed
Oct 1, 2024
Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Revnoplex <[email protected]>
Dorukyum
reviewed
Oct 4, 2024
Revnoplex
commented
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, what about just doing
self.user = user or self.user
if not self.user:
self.usercheck = False
Signed-off-by: Revnoplex <[email protected]>
Dorukyum
approved these changes
Oct 4, 2024
plun1331
approved these changes
Oct 4, 2024
baribarton
pushed a commit
to baribarton/pycord-no-potential-reconnect
that referenced
this pull request
Oct 24, 2024
…able to check (Pycord-Development#2594) * fix: don't try to do an interaction_check if there isn't a user available to check * add changelog entry * style(pre-commit): auto fixes from pre-commit.com hooks * Update CHANGELOG.md Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Revnoplex <[email protected]> * Simplify usercheck disable condition Signed-off-by: Revnoplex <[email protected]> * style(pre-commit): auto fixes from pre-commit.com hooks --------- Signed-off-by: Revnoplex <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dorukyum <[email protected]>
OmLanke
pushed a commit
to OmLanke/pycord
that referenced
this pull request
Dec 16, 2024
…able to check (Pycord-Development#2594) * fix: don't try to do an interaction_check if there isn't a user available to check * add changelog entry * style(pre-commit): auto fixes from pre-commit.com hooks * Update CHANGELOG.md Co-authored-by: Dorukyum <[email protected]> Signed-off-by: Revnoplex <[email protected]> * Simplify usercheck disable condition Signed-off-by: Revnoplex <[email protected]> * style(pre-commit): auto fixes from pre-commit.com hooks --------- Signed-off-by: Revnoplex <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dorukyum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1877
By default,
user=None
inPaginator
andPaginator.edit()
. Withauthor_check=True
being the default inPaginator
, this ultimately causes theinteraction_check
ofPaginator
to fail as it doesn't have a user to compare which ultimately meansPaginator.edit()
is broken by default. Disabling the author check if there is no user to compare allowsPaginator.edit()
to work by default.Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.