Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't try to do an interaction_check if there isn't a user available to check #2594

Merged
merged 10 commits into from
Oct 4, 2024

Conversation

Revnoplex
Copy link
Contributor

@Revnoplex Revnoplex commented Sep 30, 2024

Summary

Fixes #1877
By default, user=None in Paginator and Paginator.edit(). With author_check=True being the default in Paginator, this ultimately causes the interaction_check of Paginator to fail as it doesn't have a user to compare which ultimately means Paginator.edit() is broken by default. Disabling the author check if there is no user to compare allows Paginator.edit() to work by default.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@plun1331 plun1331 added bug Something isn't working status: in progress Work in Progess labels Sep 30, 2024
@plun1331 plun1331 added this to the v2.7 milestone Sep 30, 2024
@Revnoplex Revnoplex marked this pull request as ready for review October 1, 2024 04:23
@Revnoplex Revnoplex requested a review from a team as a code owner October 1, 2024 04:23
@pullapprove4 pullapprove4 bot requested a review from ChickenDevs October 1, 2024 04:23
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Dorukyum <[email protected]>
Signed-off-by: Revnoplex <[email protected]>
Copy link
Contributor Author

@Revnoplex Revnoplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, what about just doing

self.user = user or self.user
if not self.user:
    self.usercheck = False

@plun1331 plun1331 enabled auto-merge (squash) October 4, 2024 20:40
@plun1331 plun1331 merged commit e8311f2 into Pycord-Development:master Oct 4, 2024
25 checks passed
baribarton pushed a commit to baribarton/pycord-no-potential-reconnect that referenced this pull request Oct 24, 2024
…able to check (Pycord-Development#2594)

* fix: don't try to do an interaction_check if there isn't a user available to check

* add changelog entry

* style(pre-commit): auto fixes from pre-commit.com hooks

* Update CHANGELOG.md

Co-authored-by: Dorukyum <[email protected]>
Signed-off-by: Revnoplex <[email protected]>

* Simplify usercheck disable condition

Signed-off-by: Revnoplex <[email protected]>

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Signed-off-by: Revnoplex <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Dorukyum <[email protected]>
OmLanke pushed a commit to OmLanke/pycord that referenced this pull request Dec 16, 2024
…able to check (Pycord-Development#2594)

* fix: don't try to do an interaction_check if there isn't a user available to check

* add changelog entry

* style(pre-commit): auto fixes from pre-commit.com hooks

* Update CHANGELOG.md

Co-authored-by: Dorukyum <[email protected]>
Signed-off-by: Revnoplex <[email protected]>

* Simplify usercheck disable condition

Signed-off-by: Revnoplex <[email protected]>

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Signed-off-by: Revnoplex <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Dorukyum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status: in progress Work in Progess
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paginator View doesn't respond if paginator buttons were added via editing the message
3 participants