Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: audio plays in fast forward for first few seconds #2584

Merged
merged 6 commits into from
Sep 21, 2024
Merged

fix: audio plays in fast forward for first few seconds #2584

merged 6 commits into from
Sep 21, 2024

Conversation

felix920506
Copy link
Contributor

@felix920506 felix920506 commented Sep 20, 2024 •
edited
Loading

Summary

Audio may in some cases play in fast forward for the first few seconds when the source is slow to start, such as ffmpeg

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@felix920506 felix920506 requested a review from a team as a code owner September 20, 2024 21:27
@pullapprove4 pullapprove4 bot requested a review from FrostByte266 September 20, 2024 21:27
@pullapprove4 pullapprove4 bot requested a review from plun1331 September 20, 2024 21:27
@plun1331 plun1331 changed the title fix: Fix audio plays in fast forward for first few seconds fix: audio plays in fast forward for first few seconds Sep 20, 2024
Lulalaby
Lulalaby previously approved these changes Sep 21, 2024
View reviewed changes
@Lulalaby Lulalaby enabled auto-merge (squash) September 21, 2024 11:33
JustaSqu1d
JustaSqu1d suggested changes Sep 21, 2024
View reviewed changes
Copy link
Member

@JustaSqu1d JustaSqu1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what you're trying to say

CHANGELOG.md Outdated Show resolved Hide resolved
auto-merge was automatically disabled September 21, 2024 20:04

Head branch was pushed to by a user without write access

Lulalaby
Lulalaby reviewed Sep 21, 2024
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JustaSqu1d might this be better?

CHANGELOG.md Outdated Show resolved Hide resolved
@JustaSqu1d JustaSqu1d added priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer python Pull requests that update Python code labels Sep 21, 2024
@Lulalaby
Update CHANGELOG.md
e07fd8f 
Signed-off-by: Lala Sabathil <[email protected]>
@Lulalaby Lulalaby enabled auto-merge (squash) September 21, 2024 22:23
@Lulalaby Lulalaby merged commit ebde918 into Pycord-Development:master Sep 21, 2024
25 checks passed
baribarton pushed a commit to baribarton/pycord-no-potential-reconnect that referenced this pull request Oct 24, 2024
@felix920506 @Lulalaby @baribarton
fix: audio plays in fast forward for first few seconds (Pycord-Develo…
ef91f2d 
…pment#2584)

* Read first segment from source before starting playback

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

Signed-off-by: Lala Sabathil <[email protected]>

---------

Signed-off-by: felix920506 <[email protected]>
Signed-off-by: Lala Sabathil <[email protected]>
Co-authored-by: Lala Sabathil <[email protected]>
Co-authored-by: Lala Sabathil <[email protected]>
OmLanke pushed a commit to OmLanke/pycord that referenced this pull request Dec 16, 2024
@felix920506 @Lulalaby @OmLanke
fix: audio plays in fast forward for first few seconds (Pycord-Develo…
52f7f65 
…pment#2584)

* Read first segment from source before starting playback

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

Signed-off-by: Lala Sabathil <[email protected]>

---------

Signed-off-by: felix920506 <[email protected]>
Signed-off-by: Lala Sabathil <[email protected]>
Co-authored-by: Lala Sabathil <[email protected]>
Co-authored-by: Lala Sabathil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustaSqu1d JustaSqu1d JustaSqu1d approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@FrostByte266 FrostByte266 Awaiting requested review from FrostByte266

@plun1331 plun1331 Awaiting requested review from plun1331

Assignees
No one assigned
Labels
priority: medium Medium Priority python Pull requests that update Python code status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felix920506 @Lulalaby @JustaSqu1d