Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user-installable apps #2409

Merged
merged 74 commits into from
Jun 25, 2024
Merged

feat: user-installable apps #2409

merged 74 commits into from
Jun 25, 2024

Conversation

plun1331
Copy link
Member

@plun1331 plun1331 commented Mar 23, 2024

Installation & Testing

If you're looking to try this out, use the following:

pip install git+https://github.com/Pycord-Development/pycord@feat/ua

Note that this is still a preview from Discord, and things may be subject to change.

Docs: https://pycord--2409.org.readthedocs.build/en/2409/
Example: https://github.com/Pycord-Development/pycord/blob/feat/ua/examples/app_commands/slash_users.py


Summary

https://discord.com/developers/docs/change-log#userinstallable-apps-preview

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@plun1331 plun1331 added priority: medium Medium Priority status: in progress Work in Progess feature Implements a feature documentation needed upcoming discord feature Involves a feature not yet fully released by Discord changelog needed labels Mar 23, 2024
@plun1331 plun1331 added this to the v2.6 milestone Mar 23, 2024
@plun1331 plun1331 self-assigned this Mar 23, 2024
Signed-off-by: plun1331 <[email protected]>
@plun1331
Copy link
Member Author

Interaction.context and Interaction.authorizing_integration_owners should now always have data in them, the null checks will be left there just in case though.
ref. discord/discord-api-docs#6752

@randomnessyt92
Copy link

how do I use this

@Icebluewolf
Copy link
Contributor

It is literally the first 3 lines of the PR description. There is one example as well. You can also look at the docs raw.

@NeloBlivion
Copy link
Member

Was just confirmed there will be a new permission USE_EXTERNAL_APPS - if not granted, responses will be forced to ephemeral.

@JustaSqu1d
Copy link
Member

Was just confirmed there will be a new permission USE_EXTERNAL_APPS - if not granted, responses will be forced to ephemeral.

That pull request was just closed and will not be added "for now"

@NeloBlivion
Copy link
Member

NeloBlivion commented May 29, 2024

That pull request was just closed and will not be added "for now"

That was the pull request for replacing embedded activities permission; it is going to be a new permission now, as I linked (note the time between being closed and the DDevs message).

@JustaSqu1d
Copy link
Member

That pull request was just closed and will not be added "for now"

That was the pull request for replacing embedded activities permission; it is going to be a new permission now, as I linked (note the time between being closed and the DDevs message).

Got it

discord/commands/core.py Outdated Show resolved Hide resolved
discord/commands/core.py Outdated Show resolved Hide resolved
discord/commands/core.py Outdated Show resolved Hide resolved
examples/app_commands/slash_users.py Outdated Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
plun1331 and others added 4 commits June 25, 2024 14:05
Co-authored-by: Dorukyum <[email protected]>
Signed-off-by: plun1331 <[email protected]>
Signed-off-by: plun1331 <[email protected]>
Signed-off-by: plun1331 <[email protected]>
@plun1331 plun1331 requested a review from Dorukyum June 25, 2024 21:14
@plun1331 plun1331 marked this pull request as ready for review June 25, 2024 21:47
discord/commands/core.py Outdated Show resolved Hide resolved
discord/interactions.py Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
Dorukyum
Dorukyum previously approved these changes Jun 25, 2024
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

discord/interactions.py Outdated Show resolved Hide resolved
@Dorukyum Dorukyum merged commit 59b919f into master Jun 25, 2024
50 of 51 checks passed
@Dorukyum Dorukyum deleted the feat/ua branch June 25, 2024 23:24
baribarton pushed a commit to baribarton/pycord-no-potential-reconnect that referenced this pull request Oct 24, 2024
* add enums, do command stuff, add context to interaction

* style(pre-commit): auto fixes from pre-commit.com hooks

* add authorizing_integration_owners

* style(pre-commit): auto fixes from pre-commit.com hooks

* add application_metadata

* style(pre-commit): auto fixes from pre-commit.com hooks

* don't trust copilot

* style(pre-commit): auto fixes from pre-commit.com hooks

* update __all__

* circular import

* style(pre-commit): auto fixes from pre-commit.com hooks

* fix numbers

* h

* style(pre-commit): auto fixes from pre-commit.com hooks

* update guild_only deco to use contexts

* type

* style(pre-commit): auto fixes from pre-commit.com hooks

* deprecation warnings

* style(pre-commit): auto fixes from pre-commit.com hooks

* docs

* example

* style(pre-commit): auto fixes from pre-commit.com hooks

* edit docs

* update changelog

* style(pre-commit): auto fixes from pre-commit.com hooks

* update changelog

* add default contexts and integration_types values

* style(pre-commit): auto fixes from pre-commit.com hooks

* add default contexts and integration_types values

* h

* style(pre-commit): auto fixes from pre-commit.com hooks

* subcmds

* subcmds

* update check for desynced cmds

* h

* h

* Apply suggestions from code review

Co-authored-by: JustaSqu1d <[email protected]>
Signed-off-by: plun1331 <[email protected]>

* Update CHANGELOG.md

Seperate fix was made in Pycord-Development#2411

Signed-off-by: plun1331 <[email protected]>

* allow Message.interaction to be settable

ref. mahtoid/DiscordChatExporterPy#106

Signed-off-by: plun1331 <[email protected]>

* Update core.py

Signed-off-by: plun1331 <[email protected]>

* Update interactions.py

Signed-off-by: plun1331 <[email protected]>

* style(pre-commit): auto fixes from pre-commit.com hooks

* Update core.py

Signed-off-by: plun1331 <[email protected]>

* style(pre-commit): auto fixes from pre-commit.com hooks

* Update core.py

Signed-off-by: plun1331 <[email protected]>

* Apply suggestions from code review

Co-authored-by: Dorukyum <[email protected]>
Signed-off-by: plun1331 <[email protected]>

* Update permissions.py

Signed-off-by: plun1331 <[email protected]>

* Update permissions.py

Signed-off-by: plun1331 <[email protected]>

* style(pre-commit): auto fixes from pre-commit.com hooks

* Update interactions.py

Signed-off-by: plun1331 <[email protected]>

* Apply suggestions from code review

Signed-off-by: Dorukyum <[email protected]>

* Update discord/interactions.py

Signed-off-by: Dorukyum <[email protected]>

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Signed-off-by: plun1331 <[email protected]>
Signed-off-by: Dorukyum <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: JustaSqu1d <[email protected]>
Co-authored-by: Lala Sabathil <[email protected]>
Co-authored-by: Dorukyum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implements a feature priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer upcoming discord feature Involves a feature not yet fully released by Discord
Projects
None yet
Development

Successfully merging this pull request may close these issues.

authorizing_integration_owners deprecate and replace with interaction_metadata
9 participants