Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixes enum to support stringified annotations #2367

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix: fixes enum to support stringified annotations #2367

merged 1 commit into from
Feb 28, 2024

Conversation

jab416171
Copy link
Contributor

@jab416171 jab416171 commented Feb 28, 2024 •
edited
Loading

fixes #2359

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@jab416171 jab416171 requested a review from a team as a code owner February 28, 2024 02:31
@pullapprove4 pullapprove4 bot requested a review from BobDotCom February 28, 2024 02:31
Lulalaby
Lulalaby previously approved these changes Feb 28, 2024
View reviewed changes
@Lulalaby Lulalaby enabled auto-merge (squash) February 28, 2024 02:34
@Lulalaby Lulalaby disabled auto-merge February 28, 2024 02:42
@plun1331
Copy link
Member

CHANMGELOH

@Lulalaby Lulalaby enabled auto-merge (squash) February 28, 2024 02:45
plun1331
plun1331 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the chanhfelok

@Lulalaby Lulalaby merged commit 2276914 into Pycord-Development:master Feb 28, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plun1331 plun1331 plun1331 approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking changes in the update on master from version py-cord 2.4.1.dev214+gfc7b1042
3 participants
@jab416171 @plun1331 @Lulalaby