-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: run only local hooks for SlashCommandGroup
#2139
fix: run only local hooks for SlashCommandGroup
#2139
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2139 +/- ##
==========================================
- Coverage 33.87% 33.86% -0.02%
==========================================
Files 109 109
Lines 22353 22367 +14
==========================================
+ Hits 7573 7575 +2
- Misses 14780 14792 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type: ignore
comments were used but lacked additional rationale (unless I am missing something).
I just copy pasted the methods from |
then we keep it like that |
Signed-off-by: Om <[email protected]>
Head branch was pushed to by a user without write access
Summary
Fixes bot and cog
before_invoke
hooks being called twice for subcommands (once withctx.command
set to the group, and once withctx.command
set to the subcommand). Fixes #2134 as discussed in the discord server.This bug originally arised due to #2091 cleaning up the
prepare
logic. I personally would have considered a feature rather than a bug.Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.