-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement Avatar Decorations #2131
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2131 +/- ##
==========================================
- Coverage 33.88% 33.88% -0.01%
==========================================
Files 109 109
Lines 22343 22356 +13
==========================================
+ Hits 7571 7575 +4
- Misses 14772 14781 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
discord/discord-api-docs#5723 got merged. This can too? |
On hold till adc rolls out |
@Lulalaby update? |
There have been some recent changes. Imma look this week |
lets finish that up |
Signed-off-by: UK <[email protected]>
Decorations haven't changed much, apart from one thing; we now recieve a dict {'asset': 'a_c7e1751e8122f1b475cb3006966fb28c', 'sku_id': '1154896005045694555'} The asset ID is all we really need, does sku_id serve any purpose from a bot perspective? At the moment we still save that entire dict under |
Summary
Better late than never...?
There seems to be several different endpoints, so I've tried to include them.
Despite no longer being available, you can still get any user's decoration.
Unlike banners,
User.avatar_decoration
is always received without needing to fetch the user.Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.