Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: #1945 #2103

Merged
merged 2 commits into from
Jun 7, 2023
Merged

revert: #1945 #2103

merged 2 commits into from
Jun 7, 2023

Conversation

plun1331
Copy link
Member

@plun1331 plun1331 commented Jun 7, 2023

Summary

Reverts #1945 due to a breaking change that should not have been made at this time.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@plun1331
Copy link
Member Author

plun1331 commented Jun 7, 2023

holy shit calm down pullapprove

@plun1331 plun1331 enabled auto-merge (squash) June 7, 2023 22:11
@plun1331 plun1331 changed the title Revert "feat!: Client.on_error() improvement with new parameter (#1945)" revert: #1945 Jun 7, 2023
@plun1331 plun1331 disabled auto-merge June 7, 2023 22:12
@plun1331 plun1331 enabled auto-merge (squash) June 7, 2023 22:12
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #2103 (7a3b2d2) into master (d8377f0) will not change coverage.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2103   +/-   ##
=======================================
  Coverage   33.13%   33.13%           
=======================================
  Files          97       97           
  Lines       19139    19139           
=======================================
  Hits         6342     6342           
  Misses      12797    12797           
Flag Coverage Δ
macos-latest-3.10 33.12% <33.33%> (ø)
macos-latest-3.11 33.12% <33.33%> (ø)
macos-latest-3.8 33.13% <33.33%> (ø)
macos-latest-3.9 33.13% <33.33%> (ø)
ubuntu-latest-3.10 33.12% <33.33%> (ø)
ubuntu-latest-3.11 33.12% <33.33%> (ø)
ubuntu-latest-3.8 33.13% <33.33%> (ø)
ubuntu-latest-3.9 33.13% <33.33%> (ø)
windows-latest-3.10 33.12% <33.33%> (ø)
windows-latest-3.11 33.12% <33.33%> (ø)
windows-latest-3.8 33.13% <33.33%> (ø)
windows-latest-3.9 33.13% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/client.py 27.23% <33.33%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8377f0...7a3b2d2. Read the comment docs.

@plun1331 plun1331 added the status: awaiting review Awaiting review from a maintainer label Jun 7, 2023
@Lulalaby Lulalaby disabled auto-merge June 7, 2023 22:53
@guardboi
Copy link
Contributor

this is so sad

@Pycord-Development Pycord-Development locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants