Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: command_prefix and help_command typehints #2099

Merged
merged 7 commits into from
Jun 7, 2023
Merged

fix: command_prefix and help_command typehints #2099

merged 7 commits into from
Jun 7, 2023

Conversation

Dorukyum
Copy link
Member

@Dorukyum Dorukyum commented Jun 7, 2023 •
edited
Loading

Summary

Gets rid of annoying & meaningless type errors when initalizing commands.Bot by typehinting the command_prefix and help_command arguments properly.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Dorukyum Dorukyum added this to the v2.5 milestone Jun 7, 2023
@Dorukyum Dorukyum requested a review from a team as a code owner June 7, 2023 15:59
@Dorukyum Dorukyum self-assigned this Jun 7, 2023
@pullapprove4 pullapprove4 bot requested a review from Middledot June 7, 2023 15:59
@pullapprove4 pullapprove4 bot requested a review from Lulalaby June 7, 2023 16:00
@Dorukyum Dorukyum added status: awaiting review Awaiting review from a maintainer and removed changelog needed labels Jun 7, 2023
OmLanke
OmLanke reviewed Jun 7, 2023
View reviewed changes
discord/ext/commands/bot.py Outdated Show resolved Hide resolved
Lulalaby
Lulalaby previously approved these changes Jun 7, 2023
View reviewed changes
@Lulalaby
Copy link
Member

Lulalaby commented Jun 7, 2023

nvm the build failed xD

@Dorukyum Dorukyum marked this pull request as draft June 7, 2023 16:44
@Dorukyum Dorukyum marked this pull request as ready for review June 7, 2023 16:57
@plun1331 plun1331 enabled auto-merge (squash) June 7, 2023 18:17
@Lulalaby
Copy link
Member

Lulalaby commented Jun 7, 2023

This shit is stuck

@Lulalaby Lulalaby disabled auto-merge June 7, 2023 18:20
@plun1331 plun1331 removed the request for review from Middledot June 7, 2023 18:20
@Lulalaby Lulalaby closed this Jun 7, 2023
@Lulalaby Lulalaby reopened this Jun 7, 2023
@Lulalaby Lulalaby enabled auto-merge (squash) June 7, 2023 18:21
@plun1331
Copy link
Member

plun1331 commented Jun 7, 2023

github is a good platform

@Lulalaby
Copy link
Member

Lulalaby commented Jun 7, 2023

fixed it

@Lulalaby Lulalaby merged commit d3f6cc8 into Pycord-Development:master Jun 7, 2023
@Dorukyum Dorukyum deleted the typing-bot-args branch January 25, 2024 18:44
@Dorukyum Dorukyum restored the typing-bot-args branch January 25, 2024 18:44
@Dorukyum Dorukyum deleted the typing-bot-args branch January 25, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmLanke OmLanke OmLanke left review comments

@plun1331 plun1331 plun1331 approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees

@Dorukyum Dorukyum

Labels
priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.5
Development

Successfully merging this pull request may close these issues.
4 participants
@Dorukyum @Lulalaby @plun1331 @OmLanke