Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext.bridge): Handle BridgeCommand while unloading cogs #2048

Merged
merged 3 commits into from
May 7, 2023

Conversation

OmLanke
Copy link
Contributor

@OmLanke OmLanke commented May 5, 2023

Summary

Remove BridgeCommand correctly

Fixes #1899

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@OmLanke OmLanke requested a review from a team as a code owner May 5, 2023 18:45
@pullapprove4 pullapprove4 bot requested review from Dorukyum and Middledot May 5, 2023 18:45
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #2048 (cc625ae) into master (ea3e3db) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2048      +/-   ##
==========================================
- Coverage   33.24%   33.24%   -0.01%     
==========================================
  Files          97       97              
  Lines       19033    19036       +3     
==========================================
  Hits         6328     6328              
- Misses      12705    12708       +3     
Flag Coverage Δ
macos-latest-3.10 33.22% <0.00%> (-0.01%) ⬇️
macos-latest-3.11 33.22% <0.00%> (-0.01%) ⬇️
macos-latest-3.8 33.23% <0.00%> (-0.01%) ⬇️
macos-latest-3.9 33.23% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.10 33.22% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.11 33.22% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.8 33.23% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.9 33.23% <0.00%> (-0.01%) ⬇️
windows-latest-3.10 33.22% <0.00%> (-0.01%) ⬇️
windows-latest-3.11 33.22% <0.00%> (-0.01%) ⬇️
windows-latest-3.8 33.23% <0.00%> (-0.01%) ⬇️
windows-latest-3.9 33.23% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/cog.py 34.64% <0.00%> (-0.28%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea3e3db...cc625ae. Read the comment docs.

Lulalaby
Lulalaby previously approved these changes May 5, 2023
@Lulalaby Lulalaby enabled auto-merge (squash) May 5, 2023 19:29
@Lulalaby Lulalaby requested review from ChickenDevs and removed request for Dorukyum and Middledot May 5, 2023 19:29
auto-merge was automatically disabled May 5, 2023 20:37

Head branch was pushed to by a user without write access

@Lulalaby Lulalaby enabled auto-merge (squash) May 5, 2023 20:41
@Lulalaby Lulalaby requested a review from BobDotCom May 5, 2023 20:41
@Lulalaby Lulalaby merged commit bd28a34 into Pycord-Development:master May 7, 2023
@OmLanke OmLanke deleted the patch-3 branch May 7, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge commands doesn't work with unloading or reloading cogs
3 participants