Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: attribute error with listeners in cogs #1989

Merged
merged 10 commits into from
Mar 31, 2023
Merged

fix: attribute error with listeners in cogs #1989

merged 10 commits into from
Mar 31, 2023

Conversation

OmLanke
Copy link
Contributor

@OmLanke OmLanke commented Mar 28, 2023 •
edited
Loading

Summary

Fixes Attribute Error caused by #1957 when using listeners in cogs

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@OmLanke OmLanke requested a review from a team as a code owner March 28, 2023 12:47
@codecov
Copy link

codecov bot commented Mar 28, 2023 •
edited
Loading

Codecov Report

Merging #1989 (d524080) into master (93c28aa) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head d524080 differs from pull request most recent head fdf165e. Consider uploading reports for the commit fdf165e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1989      +/-   ##
==========================================
- Coverage   33.34%   33.33%   -0.01%     
==========================================
  Files          97       97              
  Lines       18894    18897       +3     
==========================================
  Hits         6300     6300              
- Misses      12594    12597       +3
Flag Coverage Δ
macos-latest-3.10 33.32% <0.00%> (-0.01%) ⬇️
macos-latest-3.11 33.32% <0.00%> (-0.01%) ⬇️
macos-latest-3.8 33.33% <0.00%> (-0.01%) ⬇️
macos-latest-3.9 33.33% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.10 33.32% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.11 33.32% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.8 33.33% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.9 33.33% <0.00%> (-0.01%) ⬇️
windows-latest-3.10 33.32% <0.00%> (-0.01%) ⬇️
windows-latest-3.11 33.32% <0.00%> (-0.01%) ⬇️
windows-latest-3.8 33.33% <0.00%> (-0.01%) ⬇️
windows-latest-3.9 33.33% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/client.py 27.23% <0.00%> (-0.17%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93c28aa...fdf165e. Read the comment docs.

@Lulalaby Lulalaby enabled auto-merge (squash) March 28, 2023 12:58
Lulalaby
Lulalaby previously approved these changes Mar 28, 2023
View reviewed changes
@Lulalaby Lulalaby dismissed their stale review March 28, 2023 13:23

Incorrect

auto-merge was automatically disabled March 28, 2023 13:57

Head branch was pushed to by a user without write access

@Lulalaby Lulalaby enabled auto-merge (squash) March 28, 2023 14:18
Lulalaby
Lulalaby previously approved these changes Mar 28, 2023
View reviewed changes
BobDotCom
BobDotCom reviewed Mar 28, 2023
View reviewed changes
discord/client.py Outdated Show resolved Hide resolved
auto-merge was automatically disabled March 28, 2023 16:09

Head branch was pushed to by a user without write access

@Lulalaby Lulalaby enabled auto-merge (squash) March 28, 2023 16:10
@Lulalaby Lulalaby requested a review from BobDotCom March 28, 2023 16:10
@JustaSqu1d JustaSqu1d added bug Something isn't working feature Implements a feature status: awaiting review Awaiting review from a maintainer labels Mar 29, 2023
BobDotCom
BobDotCom reviewed Mar 29, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
auto-merge was automatically disabled March 29, 2023 13:05

Head branch was pushed to by a user without write access

@Lulalaby Lulalaby enabled auto-merge (squash) March 29, 2023 13:11
@Lulalaby Lulalaby requested review from BobDotCom and Lulalaby March 29, 2023 13:11
Lulalaby
Lulalaby previously approved these changes Mar 29, 2023
View reviewed changes
BobDotCom
BobDotCom reviewed Mar 29, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@OmLanke @BobDotCom
Update CHANGELOG.md
fdf165e 
Co-authored-by: BobDotCom <[email protected]>
Signed-off-by: Om <[email protected]>
auto-merge was automatically disabled March 29, 2023 13:44

Head branch was pushed to by a user without write access

@OmLanke
Copy link
Contributor Author

OmLanke commented Mar 29, 2023

Can this be merged now?

@Lulalaby Lulalaby requested a review from BobDotCom March 29, 2023 20:19
@Lulalaby
Copy link
Member

idk ask bob

@plun1331 plun1331 enabled auto-merge (squash) March 31, 2023 14:34
@plun1331 plun1331 merged commit 614f794 into Pycord-Development:master Mar 31, 2023
@OmLanke OmLanke deleted the patch-3 branch April 24, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobDotCom BobDotCom BobDotCom approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees
No one assigned
Labels
bug Something isn't working feature Implements a feature status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@OmLanke @Lulalaby @BobDotCom @plun1331 @JustaSqu1d