-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support for text in stage #1936
Conversation
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1936 +/- ##
==========================================
- Coverage 33.33% 33.32% -0.02%
==========================================
Files 97 97
Lines 18867 18901 +34
==========================================
+ Hits 6290 6298 +8
- Misses 12577 12603 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What if we created a new class for thread related stuff, so it looks something like this:
Could you make an issue for this? I think it's a good idea, but I also agree that it's out of the scope of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog entry
Head branch was pushed to by a user without write access
for more information, see https://pre-commit.ci
Signed-off-by: UK <[email protected]>
Head branch was pushed to by a user without write access
60ff3f1
Summary
Adds support for Text channels in Stage as per discord/discord-api-docs#5928
Closes #1934
abc.Messageable
nsfw
slot toVocalGuildChannel
This PR is more or less a mirror of #1231 for
StageChannel
, however the implementation is somewhat unsatisfying; I think It'd be more ideal forVoiceChannel
andStageChannel
to inherit from_TextChannel
and then move the thread-related functions & attributes from_TextChannel
toTextChannel
andForumChannel
, but to keep in scope I went with the basic route of just mimicking the previous changes withStageChannel
. If the suggested alternative is considered a better solution then I'll go ahead with that refactor instead.Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.