-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(i18n): change localization attributes' defaults #1866
chore(i18n): change localization attributes' defaults #1866
Conversation
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1866 +/- ##
=========================================
Coverage ? 33.27%
=========================================
Files ? 97
Lines ? 19022
Branches ? 0
=========================================
Hits ? 6329
Misses ? 12693
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
IMO, to better reflect the API it should actually default to |
Well, the difference is that using an empty dictionary would remove the redundancy of needing set the dictionary before or while adding a translation and using MISSING would be more API consistent. Personally I made this pr because I found it weird that I had to that |
Still not convinced that this change is really necessary IMO |
Tbh agreeing with bob |
Mmmh, ok, I'll do that |
for more information, see https://pre-commit.ci
adapt Co-authored-by: plun1331 <[email protected]> Signed-off-by: Middledot <[email protected]>
I'm waiting for #1867 to be merged first before I update the changelog for this one |
Signed-off-by: Middledot <[email protected]>
@Middledot could you in future pls work on a branch.. codeconv is shitting itself bcs fork .-. |
* chore(i18n): make defaults for l10ns an empty dict * chore(changelog): add entry * fix(changlog): update entry oops * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat(i18n): None -> MISSING * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestions from code review adapt --------- Signed-off-by: Middledot <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: plun1331 <[email protected]> Co-authored-by: Lala Sabathil <[email protected]>
Please add a changelog entry |
Summary
EDIT: This PR makes it so that l10n attrs are by default
MISSING
to be more API consistent.I'd call this a minor breaking change.
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.