Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Sort requirements files #1768

Merged
merged 12 commits into from
Nov 11, 2022
Merged

chore(deps): Sort requirements files #1768

merged 12 commits into from
Nov 11, 2022

Conversation

BobDotCom
Copy link
Member

Summary

This PR categorizes requirement files into a requirements/ directory.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@BobDotCom BobDotCom requested review from a team as code owners November 7, 2022 22:42
@BobDotCom BobDotCom self-assigned this Nov 7, 2022
@BobDotCom BobDotCom added priority: low Low Priority status: awaiting review Awaiting review from a maintainer labels Nov 7, 2022
@BobDotCom BobDotCom added this to the v2.3 milestone Nov 7, 2022
@BobDotCom BobDotCom enabled auto-merge (squash) November 7, 2022 22:43
@BobDotCom BobDotCom changed the title chore: Sort requirements files chore(deps): Sort requirements files Nov 7, 2022
Swhistler1
Swhistler1 previously approved these changes Nov 8, 2022
Middledot
Middledot previously approved these changes Nov 8, 2022
Lulalaby
Lulalaby previously approved these changes Nov 8, 2022
Copy link
Contributor

@EmmmaTech EmmmaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the main requirements file just named _.txt? Either move the file outside of the requirements folder or name the file main.txt.

@BobDotCom
Copy link
Member Author

I took inspiration for this layout from another project, and I've been wanting to implement it for a while but only just now got to it. Not sure which project, but they used _.txt and that's why this uses it. I don't particularly see any reason against it though.

@Lulalaby
Copy link
Member

Lulalaby commented Nov 8, 2022

merge conflicts

@BobDotCom BobDotCom dismissed stale reviews from Lulalaby, Middledot, and Swhistler1 via d25e33f November 8, 2022 21:09
Middledot
Middledot previously approved these changes Nov 8, 2022
Lulalaby
Lulalaby previously approved these changes Nov 8, 2022
@BobDotCom BobDotCom dismissed stale reviews from Lulalaby and Middledot via 99de6ab November 10, 2022 19:41
@BobDotCom BobDotCom requested review from Lulalaby and Dorukyum and removed request for Lulalaby November 10, 2022 20:14
@BobDotCom BobDotCom disabled auto-merge November 11, 2022 21:38
@BobDotCom BobDotCom merged commit 46f971c into master Nov 11, 2022
@BobDotCom BobDotCom deleted the requirements branch November 11, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants