Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VOICE_SERVER_UPDATE error #1624

Merged
merged 4 commits into from
Sep 14, 2022
Merged

Fix VOICE_SERVER_UPDATE error #1624

merged 4 commits into from
Sep 14, 2022

Conversation

BobDotCom
Copy link
Member

Summary

This pull request reverts #1273 as it caused a separate issue.
Fixes #1567

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@BobDotCom BobDotCom requested a review from Dorukyum September 7, 2022 23:42
@BobDotCom BobDotCom self-assigned this Sep 7, 2022
@BobDotCom BobDotCom enabled auto-merge (squash) September 7, 2022 23:43
@BobDotCom BobDotCom requested review from Middledot, a team and FrostByte266 and removed request for a team September 7, 2022 23:43
Dorukyum
Dorukyum approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, the previous issue seems to be resolved

@BobDotCom BobDotCom merged commit 0847384 into master Sep 14, 2022
@Dorukyum Dorukyum deleted the fix-voice-update branch September 14, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@Middledot Middledot Awaiting requested review from Middledot

@FrostByte266 FrostByte266 Awaiting requested review from FrostByte266 FrostByte266 is a code owner automatically assigned from Pycord-Development/maintainers

Assignees

@BobDotCom BobDotCom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VOICE_SERVER_UPDATE can cause voice bots to leave and not rejoin
3 participants
@BobDotCom @Lulalaby @Dorukyum