Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename original_message to original_response #1609

Merged
merged 27 commits into from
Oct 2, 2022
Merged

Rename original_message to original_response #1609

merged 27 commits into from
Oct 2, 2022

Conversation

Ombucha
Copy link
Contributor

@Ombucha Ombucha commented Aug 31, 2022 •
edited by BobDotCom
Loading

Summary

This PR renames original_message to original_response.

Depends on #1657

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@EmmmaTech
Copy link
Contributor

This is a big breaking change. edit_original_message, delete_original_message, and any other attributes/methods you renamed should be aliases instead.

@Ombucha
Copy link
Contributor Author

Ombucha commented Aug 31, 2022

discord.py seems to have made this same breaking change, yet has not added any aliases.

@EmmmaTech
Copy link
Contributor

discord.py seems to have made this same breaking change, yet has not added any aliases.

Then why does that mean you shouldn't make aliases in this PR. Remember, this library isn't a part of discord.py anymore, it's its own thing

@JustaSqu1d
Copy link
Member

discord.py seems to have made this same breaking change, yet has not added any aliases.

Why does it have to be discord.py?

@Ombucha
Copy link
Contributor Author

Ombucha commented Aug 31, 2022 •
edited
Loading

This is a big breaking change. edit_original_message, delete_original_message, and any other attributes/methods you renamed should be aliases instead.

Do I have to mention the alias in the docs?

@EmmmaTech
Copy link
Contributor

This is a big breaking change. edit_original_message, delete_original_message, and any other attributes/methods you renamed should be aliases instead.

Do I have to mention the alias in the docs?

Yes

@Ombucha
Copy link
Contributor Author

Ombucha commented Aug 31, 2022

@emretech The requested changes have been made.

EmmmaTech
EmmmaTech suggested changes Aug 31, 2022
View reviewed changes
discord/interactions.py Outdated Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
@Ombucha Ombucha requested a review from EmmmaTech August 31, 2022 05:55
@EmmmaTech
Copy link
Contributor

@emretech The requested changes have been made.

You don't have to tell me BTW. Just request for my review again

EmmmaTech
EmmmaTech previously approved these changes Aug 31, 2022
View reviewed changes
@BobDotCom BobDotCom self-requested a review September 6, 2022 14:32
@Ombucha Ombucha requested review from plun1331 and EmmmaTech and removed request for BobDotCom, plun1331 and EmmmaTech September 8, 2022 04:04
EmmmaTech
EmmmaTech reviewed Sep 8, 2022
View reviewed changes
discord/interactions.py Outdated Show resolved Hide resolved
auto-merge was automatically disabled October 1, 2022 15:20

Head branch was pushed to by a user without write access

BobDotCom
BobDotCom reviewed Oct 1, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Lulalaby Lulalaby requested review from BobDotCom and removed request for plun1331 October 2, 2022 10:17
BobDotCom
BobDotCom previously approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@BobDotCom BobDotCom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shortened the changelog entries a bit

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
BobDotCom
BobDotCom previously approved these changes Oct 2, 2022
View reviewed changes
@BobDotCom BobDotCom enabled auto-merge (squash) October 2, 2022 20:29
ChickenDevs
ChickenDevs previously approved these changes Oct 2, 2022
View reviewed changes
@BobDotCom BobDotCom dismissed stale reviews from ChickenDevs and themself via a9b6f15 October 2, 2022 21:29
@BobDotCom BobDotCom requested a review from ChickenDevs October 2, 2022 21:29
@BobDotCom BobDotCom disabled auto-merge October 2, 2022 21:33
@BobDotCom BobDotCom merged commit 88d43dc into Pycord-Development:master Oct 2, 2022
BobDotCom added a commit that referenced this pull request Oct 3, 2022
@Ombucha @BobDotCom
Fix changelog for #1609 (#1663)
9cd72bc 
* Add a missing parenthesis

* Fix incorrect PR link

Co-authored-by: BobDotCom <[email protected]>
@Soheab
Copy link
Contributor

Soheab commented Oct 24, 2022 •
edited
Loading

discord.py seems to have made this same breaking change, yet has not added any aliases.

This was changed before the stable release of discord.py 2.0 thus making it not a breaking change... because you know it's a major version change and this method (or even the whole class) didn't exist before 2.0. Also yes like others have already mentioned, this lib has nothing to do with discord.py so it shouldn't even be brought up.

didn't notice that was from 2 months ago

celsiusnarhwal added a commit to celsiusnarhwal/3515.games that referenced this pull request Jan 6, 2023
@celsiusnarhwal
change interaction.edit_original_message to interaction.edit_original…
27eb35f 
…_response

interaction.edit_original_message was deprecated in Pycord 2.2.0. Pycord-Development/pycord#1609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plun1331 plun1331 plun1331 left review comments

@TurnrDev TurnrDev TurnrDev left review comments

@BobDotCom BobDotCom BobDotCom approved these changes

@EmmmaTech EmmmaTech EmmmaTech left review comments

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

@Middledot Middledot Awaiting requested review from Middledot

@ChickenDevs ChickenDevs Awaiting requested review from ChickenDevs

Assignees

@Ombucha Ombucha

Labels
status: in progress Work in Progess
Projects
Pycord Releases
Status: Done
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.
9 participants
@Ombucha @EmmmaTech @JustaSqu1d @BobDotCom @Lulalaby @Soheab @TurnrDev @plun1331 @ChickenDevs