Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SlashCommandGroup descriptions pretending to be optional #1539

Merged
merged 1 commit into from
Jul 31, 2022
Merged

Fix SlashCommandGroup descriptions pretending to be optional #1539

merged 1 commit into from
Jul 31, 2022

Conversation

Middledot
Copy link
Member

Summary

Putting no description makes the description validator error out.
Fix #1503

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Middledot
fix: SlashCommandGroup descriptions
167b844 
they're supposed to be optional but break when put into validation
@Middledot Middledot mentioned this pull request Jul 31, 2022
Closed
3 tasks
searchify7
searchify7 approved these changes Jul 31, 2022
View reviewed changes
Copy link

@searchify7 searchify7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@Dorukyum Dorukyum merged commit a8a4a29 into Pycord-Development:master Jul 31, 2022
@Middledot Middledot deleted the fix-slashgroups-desc branch August 1, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@searchify7 searchify7 searchify7 approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

@EmmmaTech EmmmaTech EmmmaTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SlashCommandGroup() raises "description must be of type str" but description is optional
4 participants
@Middledot @EmmmaTech @Dorukyum @searchify7