Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update content retrieval from AutoModActionExecution #1521

Merged
merged 3 commits into from
Jul 24, 2022
Merged

Update content retrieval from AutoModActionExecution #1521

merged 3 commits into from
Jul 24, 2022

Conversation

NeloBlivion
Copy link
Member

Update to fix data["content"] raising a KeyError for Automod Events when the bot lacks the Message Content intent.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@NeloBlivion
Update content retrieval from AutoModActionExecution
56b806a 
Update to fix `data["content"]` raising an Error when the bot [lacks the Message Content intent](https://discord.com/developers/docs/change-log#jun-21-2022).
Lulalaby
Lulalaby previously approved these changes Jul 24, 2022
View reviewed changes
@Lulalaby Lulalaby enabled auto-merge (rebase) July 24, 2022 13:54
@Lulalaby Lulalaby requested review from Dorukyum and Middledot July 24, 2022 13:54
@Lulalaby Lulalaby added bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer Merge with rebase labels Jul 24, 2022
Dorukyum
Dorukyum requested changes Jul 24, 2022
View reviewed changes
discord/raw_models.py Outdated Show resolved Hide resolved
discord/raw_models.py Outdated Show resolved Hide resolved
auto-merge was automatically disabled July 24, 2022 14:00

Head branch was pushed to by a user without write access

@NeloBlivion @Dorukyum
Update discord/raw_models.py
3811f78 
Make Optional

Co-authored-by: Dorukyum <[email protected]>
@NeloBlivion @Dorukyum
Update discord/raw_models.py
6e9a83c 
Make Optional

Co-authored-by: Dorukyum <[email protected]>
@Lulalaby
Copy link
Member

Ah right

@Lulalaby Lulalaby requested a review from Dorukyum July 24, 2022 14:01
@Yuvaraja28
Copy link

Here's the Full Traceback
traceback

Dorukyum
Dorukyum approved these changes Jul 24, 2022
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Dorukyum Dorukyum merged commit ede04b7 into Pycord-Development:master Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@Middledot Middledot Awaiting requested review from Middledot

Assignees
No one assigned
Labels
bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NeloBlivion @Lulalaby @Yuvaraja28 @Dorukyum