-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large code/documentation cleanup #1476
Large code/documentation cleanup #1476
Conversation
Please don't say this should go into release too 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh LGTM so far, @Dorukyum what you think
Personally I think instead that another Black linting PR (that re-adds the CI with some differences) would be better for this instead of doing it in this PR. |
Co-authored-by: Dorukyum <[email protected]>
Co-authored-by: plun1331 <[email protected]>
Should this be done? I don't see a reason to undo those changes just so it can be done again, but if others think so then I can revert them. |
Co-authored-by: Lala Sabathil <[email protected]>
I meant only featureable ^^ I read your whole pr in bed because I couldn't sleep XD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again I'm sleepy and once more I approve this pr as LGTM.
And because I only fixed a merge conflict YEEEEEEEEET
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise lgtm
Co-authored-by: Middledot <[email protected]>
Co-authored-by: Middledot <[email protected]>
Co-authored-by: Middledot <[email protected]>
Head branch was pushed to by a user without write access
Summary
This PR does a ton of things, but I'll attempt to summarize here:
(not all fixed, see below for remaining)._Undefined
in favor ofMISSING
inabc.py
.tuple
returns to returnval, val, ...
instead of(val, val, ...)
.Regarding broken links, there are still a few that remain and I have yet to get around to fixing yet. Namely:Auto mod objects (i.e.(will be handled in a separate PR)AutoModRule
,AutoModActionExecutionEvent
, and more) that are referenced in the documentation (here and here from what I've found) are broken links as the objects are not currently listed anywhere in the documentation.Any references toForumChannel
in the documentation are broken as it is not currently listed anywhere. (found here, here, here, here, and here so far.)Not all members ofTextChannel
are being displayed on the docs, resulting in missing attributes on the object itself and a broken reference. (broken reference found here, haven't found any others so far.)Also, lastly, this PR will probably remain in draft until the broken links listed above are fixed (any help is much appreciated, I can't do much more documentation work for my own sanity) and the changes made here are ensured to not cause any issues (once again, any testing done is much appreciated).Information
Checklist
type: ignore
comments were used, a comment is also left explaining why.