Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PartialMessageChannel to be in voice channels (which now support text) #1441

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Allow PartialMessageChannel to be in voice channels (which now support text) #1441

merged 1 commit into from
Jun 24, 2022

Conversation

UP929312
Copy link
Contributor

raise TypeError(f"Expected TextChannel, VoiceChannel, DMChannel or Thread not {type(channel)!r}")
TypeError: Expected TextChannel, VoiceChannel, DMChannel or Thread not <class 'discord.channel.VoiceChannel'>

(from: https://discord.com/channels/881207955029110855/881735314987708456/989938163134918687)

This needs testing is so currently a draft

Checklist

  • [] If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@UP929312 UP929312 marked this pull request as draft June 24, 2022 17:09
@Lulalaby Lulalaby marked this pull request as ready for review June 24, 2022 17:10
@Lulalaby Lulalaby enabled auto-merge (rebase) June 24, 2022 17:11
@Lulalaby Lulalaby requested a review from Dorukyum June 24, 2022 17:11
@Lulalaby
Copy link
Member

LGTM we can merge that without testing

@Lulalaby Lulalaby merged commit cf2db7e into Pycord-Development:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants