Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deferring #1379

Merged
merged 3 commits into from
May 24, 2022
Merged

Fix deferring #1379

merged 3 commits into from
May 24, 2022

Conversation

plun1331
Copy link
Member

@plun1331 plun1331 commented May 24, 2022 •
edited
Loading

Summary

Allows deferring with either deferred_channel_message or deferred_message_update on modal interactions.
The library currently forces a defer on a modal submit to become a channel message.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed) - Potentially breaking as it may change response types for modal submit defers
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Lulalaby Lulalaby enabled auto-merge (squash) May 24, 2022 00:47
Lulalaby
Lulalaby previously approved these changes May 24, 2022
View reviewed changes
@Lulalaby Lulalaby requested review from Dorukyum and Middledot May 24, 2022 12:48
@Lulalaby Lulalaby added bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. feature Implements a feature Merge with squash and removed bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. labels May 24, 2022
Middledot
Middledot reviewed May 24, 2022
View reviewed changes
Copy link
Member

@Middledot Middledot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some extra whitespaces

discord/interactions.py Outdated Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
@Middledot Middledot requested a review from Lulalaby May 24, 2022 14:54
Lulalaby
Lulalaby approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@Lulalaby Lulalaby merged commit 7c4a7b0 into Pycord-Development:master May 24, 2022
@plun1331 plun1331 deleted the fix-defer branch May 24, 2022 20:54
Lulalaby pushed a commit that referenced this pull request Jun 11, 2022
@plun1331 @Lulalaby
Fix deferring (#1379)
c719cf9 
Update interactions.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Middledot Middledot Middledot approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

Assignees

@plun1331 plun1331

Labels
bug Something isn't working feature Implements a feature priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
Pycord Releases
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plun1331 @Lulalaby @Middledot