Add cchardetect CLI script
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
craigds
commented
May 9, 2017
craigds
commented
|
Hi @craigds Thanks a lot!!!!!!!!!!!!!! I left a comment on code. Please check it. Thanks. |
PyYoshi
requested changes
May 13, 2017
bin/cchardetect
Outdated
|
|
||
| def main(): | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument('files', nargs='+', help="Files to detect encoding of", type=argparse.FileType('r')) |
There was a problem hiding this comment.
it should be argparse.FileType('rb') because Python 3.x will not work.
There was a problem hiding this comment.
good catch. fixed :)
PyYoshi
approved these changes
May 15, 2017
|
@craigds. Thank you! |
This was referenced May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.