Skip to content

Conversation

@grlee77
Copy link
Contributor

@grlee77 grlee77 commented Aug 22, 2019

The motivation here is to help GitHub correctly auto-identify the LICENSE as MIT.

(following the example of SciPy who did this recently for the same reason)

This is done partly to help GitHub correctly identify the LICENSE as MIT
@grlee77 grlee77 merged commit bc7c671 into PyWavelets:master Aug 22, 2019
@grlee77
Copy link
Contributor Author

grlee77 commented Aug 22, 2019

no point in checking CI here. After merging the license is now listed as "MIT" again, so it worked.

@rgommers
Copy link
Member

the thing to check is that this does get included in the wheel (with bdist_wheel)

@grlee77
Copy link
Contributor Author

grlee77 commented Aug 22, 2019

Thanks, I checked and it seems to get included (probably via include *.txt in MANIFEST.in)

@grlee77 grlee77 added this to the v1.1 milestone Sep 28, 2019
@grlee77
Copy link
Contributor Author

grlee77 commented Oct 4, 2019

It looks like I neglected to include a copy of the NumPy and SciPy license files as part of this PR. I can make a follow-up to add a copy under /doc or something.

@rgommers
Copy link
Member

rgommers commented Oct 5, 2019

Hmm yeah, you're right that that's technically required I think. No one does this though, community projects in the ecosystem liberally share code; stuff regularly moves between NumPy, SciPy, Statsmodels, Scikit-learn, Scikit-image, etc. Having everyone include all of each others' licenses would become very messy. So happy to leave as is.

@grlee77 grlee77 deleted the license_fix branch November 13, 2019 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants