-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-introduce fix for Hydra directory sync with multiple process #5993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanNaren
added
bug
Something isn't working
distributed
Generic distributed-related topic
3rd party
Related to a 3rd-party
labels
Feb 15, 2021
SeanNaren
requested review from
ananthsub,
awaelchli,
carmocca,
tchaton and
kaushikb11
February 15, 2021 23:00
awaelchli
approved these changes
Feb 15, 2021
Codecov Report
@@ Coverage Diff @@
## master #5993 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 160 160
Lines 11344 11344
======================================
- Hits 10554 10525 -29
- Misses 790 819 +29 |
I'll try get a test for this in place, I had difficulty the first time but this time round might be doable... |
carmocca
approved these changes
Feb 15, 2021
kaushikb11
reviewed
Feb 16, 2021
kaushikb11
approved these changes
Feb 16, 2021
tchaton
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3rd party
Related to a 3rd-party
bug
Something isn't working
distributed
Generic distributed-related topic
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Re-introduce fix from #5629 that was left out of the accelerator refactor highlighted by @mees! Also there seems there was an edge case that caused some issues with @mees setup, and he suggested a slight modification to the fix.
Have confirmed locally that this fixes the issue.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃