Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce fix for Hydra directory sync with multiple process #5993

Merged
merged 7 commits into from
Feb 17, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Feb 15, 2021

What does this PR do?

Re-introduce fix from #5629 that was left out of the accelerator refactor highlighted by @mees! Also there seems there was an edge case that caused some issues with @mees setup, and he suggested a slight modification to the fix.

Have confirmed locally that this fixes the issue.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added bug Something isn't working distributed Generic distributed-related topic 3rd party Related to a 3rd-party labels Feb 15, 2021
@SeanNaren SeanNaren added this to the 1.2 milestone Feb 15, 2021
@SeanNaren SeanNaren self-assigned this Feb 15, 2021
@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #5993 (4593672) into master (6a9cec4) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5993   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         160     160           
  Lines       11344   11344           
======================================
- Hits        10554   10525   -29     
- Misses        790     819   +29     

@SeanNaren
Copy link
Contributor Author

I'll try get a test for this in place, I had difficulty the first time but this time round might be doable...

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@SeanNaren SeanNaren enabled auto-merge (squash) February 17, 2021 11:01
@SeanNaren SeanNaren merged commit ba62900 into master Feb 17, 2021
@SeanNaren SeanNaren deleted the fix/5629_redo_hydra branch February 17, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party bug Something isn't working distributed Generic distributed-related topic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants