Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce fix for Hydra directory sync with multiple process #5993

Merged
merged 7 commits into from
Feb 17, 2021
Merged

Re-introduce fix for Hydra directory sync with multiple process #5993

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
86356dc
Add hydra fix that was missing from master
Feb 15, 2021
7004dab
Remove error commas
Feb 15, 2021
e556ae0
Merge branch 'master' into fix/5629_redo_hydra
SeanNaren Feb 16, 2021
4e8e3a1
Merge branch 'master' into fix/5629_redo_hydra
mergify[bot] Feb 16, 2021
b0cb72a
Merge branch 'master' into fix/5629_redo_hydra
mergify[bot] Feb 16, 2021
b86a8ef
Merge branch 'master' into fix/5629_redo_hydra
mergify[bot] Feb 16, 2021
d3c3ae5
Merge branch 'master' into fix/5629_redo_hydra
Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pytorch_lightning/plugins/training_type/ddp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,8 @@ def _call_children_scripts(self):
if _HYDRA_AVAILABLE:
if HydraConfig.initialized():
cwd = get_original_cwd()
os_cwd = f'"{os.getcwd()}"'
kaushikb11 marked this conversation as resolved.
Show resolved Hide resolved
command += [f'hydra.run.dir={os_cwd}', f'hydra.job.name=train_ddp_process_{local_rank}']
proc = subprocess.Popen(command, env=env_copy, cwd=cwd)
self.interactive_ddp_procs.append(proc)

Expand Down