-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove legacy plugins #5950
Merged
Merged
remove legacy plugins #5950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @Borda! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-02-16 18:03:04 UTC |
Borda
requested review from
carmocca,
SeanNaren,
tchaton and
williamFalcon
as code owners
February 13, 2021 00:05
awaelchli
approved these changes
Feb 13, 2021
carmocca
approved these changes
Feb 13, 2021
justusschock
approved these changes
Feb 13, 2021
awaelchli
force-pushed
the
refactor/legacy-cleanup3
branch
from
February 14, 2021 16:12
e3599dd
to
f6095d6
Compare
awaelchli
changed the title
[blocked by #5949] remove legacy plugins
remove legacy plugins
Feb 14, 2021
Codecov Report
@@ Coverage Diff @@
## master #5950 +/- ##
=======================================
+ Coverage 90% 93% +3%
=======================================
Files 170 159 -11
Lines 11784 11093 -691
=======================================
- Hits 10664 10318 -346
+ Misses 1120 775 -345 |
tchaton
approved these changes
Feb 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
removing legacy plugins, follow up to #5743
cc: @awaelchli
there are some lining to accelerators so it would be better to go after #5949
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃