Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove legacy plugins #5950

Merged
merged 26 commits into from
Feb 16, 2021
Merged

remove legacy plugins #5950

merged 26 commits into from
Feb 16, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 12, 2021

What does this PR do?

removing legacy plugins, follow up to #5743
cc: @awaelchli
there are some lining to accelerators so it would be better to go after #5949

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactor label Feb 12, 2021
@Borda Borda added this to the 1.2 milestone Feb 12, 2021
@pep8speaks
Copy link

pep8speaks commented Feb 12, 2021

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-16 18:03:04 UTC

@Borda Borda changed the title remove legacy plugins [blocked by #5949] remove legacy plugins Feb 12, 2021
@Borda Borda marked this pull request as ready for review February 13, 2021 00:05
@awaelchli awaelchli force-pushed the refactor/legacy-cleanup3 branch from e3599dd to f6095d6 Compare February 14, 2021 16:12
@mergify mergify bot removed the has conflicts label Feb 14, 2021
@Borda Borda requested a review from edenlightning as a code owner February 14, 2021 16:15
@awaelchli awaelchli changed the title [blocked by #5949] remove legacy plugins remove legacy plugins Feb 14, 2021
@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

Merging #5950 (b6c3575) into master (fcfa7fa) will increase coverage by 3%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #5950    +/-   ##
=======================================
+ Coverage      90%     93%    +3%     
=======================================
  Files         170     159    -11     
  Lines       11784   11093   -691     
=======================================
- Hits        10664   10318   -346     
+ Misses       1120     775   -345     

@Borda Borda added the ready PRs ready to be merged label Feb 14, 2021
@Borda Borda enabled auto-merge (squash) February 14, 2021 17:39
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda added the priority: 1 Medium priority task label Feb 16, 2021
@Borda Borda merged commit 1c87f1f into master Feb 16, 2021
@Borda Borda deleted the refactor/legacy-cleanup3 branch February 16, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: 1 Medium priority task ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants