Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: passing wrong strings for scheduler interval doesn't throw an error #5923

Merged

Conversation

ddrevicky
Copy link
Contributor

@ddrevicky ddrevicky commented Feb 11, 2021

What does this PR do?

  • Raises MisconfigurationException if scheduler's interval parameter is not one of epoch, step
  • Adds a test case to verify this behavior

Fixes #5548

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #5923 (2341960) into master (ae19c97) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #5923    +/-   ##
=======================================
- Coverage      88%     83%    -5%     
=======================================
  Files         184     184            
  Lines       13200   13202     +2     
=======================================
- Hits        11666   10981   -685     
- Misses       1534    2221   +687     

@Borda Borda changed the title Fix #5548 passing wrong strings for scheduler interval doesn't throw an error Fix: passing wrong strings for scheduler interval doesn't throw an error Feb 11, 2021
@Borda Borda added the bug Something isn't working label Feb 11, 2021
@Borda Borda added this to the 1.2 milestone Feb 11, 2021
@mergify mergify bot removed the has conflicts label Feb 11, 2021
@carmocca carmocca added the ready PRs ready to be merged label Feb 12, 2021
@carmocca carmocca modified the milestones: 1.2, 1.3, 1.2.x Feb 12, 2021
@rohitgr7 rohitgr7 merged commit 309ce7a into Lightning-AI:master Feb 12, 2021
@Borda Borda modified the milestones: 1.2.x, 1.2 Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing wrong strings for scheduler interval doesn't throw an error
5 participants