-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: passing wrong strings for scheduler interval doesn't throw an error #5923
Merged
rohitgr7
merged 13 commits into
Lightning-AI:master
from
ddrevicky:fix/5548-scheduler-interval-arg
Feb 12, 2021
Merged
Fix: passing wrong strings for scheduler interval doesn't throw an error #5923
rohitgr7
merged 13 commits into
Lightning-AI:master
from
ddrevicky:fix/5548-scheduler-interval-arg
Feb 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddrevicky
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
February 11, 2021 15:39
Codecov Report
@@ Coverage Diff @@
## master #5923 +/- ##
=======================================
- Coverage 88% 83% -5%
=======================================
Files 184 184
Lines 13200 13202 +2
=======================================
- Hits 11666 10981 -685
- Misses 1534 2221 +687 |
Borda
changed the title
Fix #5548 passing wrong strings for scheduler interval doesn't throw an error
Fix: passing wrong strings for scheduler interval doesn't throw an error
Feb 11, 2021
Borda
reviewed
Feb 11, 2021
Co-authored-by: Jirka Borovec <[email protected]>
ddrevicky
commented
Feb 11, 2021
carmocca
reviewed
Feb 11, 2021
carmocca
approved these changes
Feb 11, 2021
SkafteNicki
approved these changes
Feb 12, 2021
rohitgr7
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
MisconfigurationException
if scheduler's interval parameter is not one ofepoch
,step
Fixes #5548
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃