Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing wrong strings for scheduler interval doesn't throw an error #5548

Closed
finnBsch opened this issue Jan 17, 2021 · 3 comments · Fixed by #5923
Closed

Passing wrong strings for scheduler interval doesn't throw an error #5548

finnBsch opened this issue Jan 17, 2021 · 3 comments · Fixed by #5923
Labels
bug Something isn't working good first issue Good for newcomers help wanted Open to be worked on priority: 2 Low priority task

Comments

@finnBsch
Copy link

I noticed that when you pass an interval as scheduler parameter that is not 'step' or 'epoch' (for example 'batch') there's no error, it just trains without ever calling the scheduler. Had to look into the source code because I didn't find much info about it in the documentation

@finnBsch finnBsch added bug Something isn't working help wanted Open to be worked on labels Jan 17, 2021
@Borda Borda added the priority: 2 Low priority task label Jan 17, 2021
@Borda
Copy link
Member

Borda commented Jan 17, 2021

@finnBsch that is a good observation, mind sending a PR with adding assert or check/raise with exception?

@finnBsch
Copy link
Author

I am not sure where the argument gets assigned.. I just know that there is no check for it in update_learning_rates, however I am sure that it gets assigned somewhere earlier but I cannot find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Open to be worked on priority: 2 Low priority task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants