Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading yaml #5619

Merged
merged 8 commits into from
Jan 25, 2021
Merged

Fix loading yaml #5619

merged 8 commits into from
Jan 25, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 22, 2021

What does this PR do?

Fix loading YAML, resolves temporary ban version #5609
follows suggestions from yaml/pyyaml#482 (comment)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working logger Related to the Loggers checkpointing Related to checkpointing priority: 1 Medium priority task labels Jan 22, 2021
@Borda Borda added this to the 1.2 milestone Jan 22, 2021
@Borda Borda self-assigned this Jan 22, 2021
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #5619 (62f93a3) into release/1.2-dev (dfbb592) will decrease coverage by 0%.
The diff coverage is 93%.

@@               Coverage Diff                @@
##           release/1.2-dev   #5619    +/-   ##
================================================
- Coverage               93%     92%    -0%     
================================================
  Files                  146     153     +7     
  Lines                10315   10840   +525     
================================================
+ Hits                  9549   10017   +468     
- Misses                 766     823    +57     

@Borda Borda added the ready PRs ready to be merged label Jan 23, 2021
@Borda Borda merged commit 304f9c5 into release/1.2-dev Jan 25, 2021
@Borda Borda deleted the fix/yaml branch January 25, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working checkpointing Related to checkpointing logger Related to the Loggers priority: 1 Medium priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants