Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to_disk to use fsspec for remote file support #3930

Merged
merged 9 commits into from
Oct 7, 2020

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Oct 7, 2020

What does this PR do?

Fixes #3890

cc @nateraw @awaelchli

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team October 7, 2020 06:34
@Borda Borda added the feature Is an improvement or enhancement label Oct 7, 2020
@mergify mergify bot requested a review from a team October 7, 2020 09:47
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #3930 into master will decrease coverage by 0%.
The diff coverage is 89%.

@@          Coverage Diff           @@
##           master   #3930   +/-   ##
======================================
- Coverage      86%     86%   -0%     
======================================
  Files         113     113           
  Lines        8551    8559    +8     
======================================
+ Hits         7361    7367    +6     
- Misses       1190    1192    +2     

@williamFalcon williamFalcon merged commit d3f40d6 into Lightning-AI:master Oct 7, 2020
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightning Module's to_disk should use fsspec to write reusults
3 participants