-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable profilers to write to remote files with fsspec #4162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4162 +/- ##
======================================
Coverage 93% 93%
======================================
Files 111 111
Lines 8068 8019 -49
======================================
- Hits 7478 7454 -24
+ Misses 590 565 -25 |
Enable profilers to use write to remote files with fsspec
ananthsub
force-pushed
the
profiler-fsspec
branch
from
October 24, 2020 16:51
587063f
to
ebdbfc0
Compare
ananthsub
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
SeanNaren,
tchaton,
teddykoker and
williamFalcon
as code owners
October 24, 2020 16:56
awaelchli
approved these changes
Oct 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
awaelchli
added
feature
Is an improvement or enhancement
ready
PRs ready to be merged
labels
Oct 24, 2020
Co-authored-by: Adrian Wälchli <[email protected]>
ananthsub
changed the title
Enable profilers to use write to remote files with fsspec
Enable profilers to write to remote files with fsspec
Oct 25, 2020
Borda
approved these changes
Oct 25, 2020
ydcjeff
approved these changes
Oct 25, 2020
rohitgr7
approved these changes
Oct 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Similar to #3930
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃