Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save last model after saving top_k when save_last=True #2881

Merged
merged 9 commits into from
Aug 8, 2020

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 8, 2020

What does this PR do?

Fixes #2680

The checkpoint named "last.ckpt" should be saved last, literally, after saving all the top_k, because these will update the state for best_model_score and best_model_path, and if we don't save last these infos won't land in the checkpoint.

Note: Test fails on master

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli marked this pull request as draft August 8, 2020 04:29
@mergify mergify bot requested a review from a team August 8, 2020 04:29
@awaelchli awaelchli marked this pull request as ready for review August 8, 2020 04:51
@codecov
Copy link

codecov bot commented Aug 8, 2020

Codecov Report

Merging #2881 into master will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #2881    +/-   ##
=======================================
- Coverage      90%     86%    -4%     
=======================================
  Files          79      79            
  Lines        7259    7229    -30     
=======================================
- Hits         6524    6217   -307     
- Misses        735    1012   +277     

@awaelchli awaelchli added the bug Something isn't working label Aug 8, 2020
@mergify mergify bot requested a review from a team August 8, 2020 06:54
@mergify mergify bot requested a review from a team August 8, 2020 08:21
@Borda Borda added the ready PRs ready to be merged label Aug 8, 2020
@williamFalcon williamFalcon merged commit f798cff into master Aug 8, 2020
@awaelchli awaelchli deleted the bugfix/save_last_order branch August 8, 2020 11:11
@Borda Borda added this to the 0.9.0 milestone Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkpoint saving order
3 participants