-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the case where logger=None is passed to Trainer #12249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellepintz
requested review from
tchaton,
carmocca,
williamFalcon,
Borda,
SeanNaren,
awaelchli,
justusschock,
kaushikb11 and
rohitgr7
as code owners
March 6, 2022 17:48
ananthsub
reviewed
Mar 6, 2022
ananthsub
reviewed
Mar 6, 2022
ananthsub
reviewed
Mar 7, 2022
krshrimali
approved these changes
Mar 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this. ⚡ Before we forget about this, can you also create an issue from this comment?
ananthsub
approved these changes
Mar 7, 2022
rohitgr7
approved these changes
Mar 7, 2022
awaelchli
approved these changes
Mar 9, 2022
ananthsub
reviewed
Mar 11, 2022
Borda
approved these changes
Mar 14, 2022
Borda
reviewed
Mar 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add chlog
carmocca
approved these changes
Mar 14, 2022
Ready to be merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a small bug introduced in #11920 for the case where logger=None is passed to the Trainer.
Before this PR, when logger=None is passed to the Trainer, we see this error:
full output: https://gist.github.com/daniellepintz/f603473b82c1f21d8299eaae56b33001
This is because trainer.loggers is being set to
[None]
here: https://github.com/PyTorchLightning/pytorch-lightning/blob/5df519572f78ae5e23b0aab18fcbda06df7ff8dd/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py#L101so in the
log_dir
property it thinkslen(self.loggers) == 1
.Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃