Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed the DDPSpawnPlugin to DDPSpawnStrategy #11145

Merged
merged 10 commits into from
Dec 21, 2021

Conversation

four4fish
Copy link
Contributor

@four4fish four4fish commented Dec 18, 2021

What does this PR do?

ddp_spawn_plugin updated as well

part of #10549

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@four4fish four4fish added this to the 1.6 milestone Dec 18, 2021
@four4fish four4fish changed the title Rename/ddp spawn Renamed the DDPSpawnPlugin to DDPSpawnStrategy Dec 18, 2021
@mergify mergify bot removed the has conflicts label Dec 20, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@ananthsub ananthsub added the breaking change Includes a breaking change label Dec 20, 2021
@mergify mergify bot added the ready PRs ready to be merged label Dec 20, 2021
docs/source/advanced/training_tricks.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Dec 21, 2021
@ananthsub ananthsub enabled auto-merge (squash) December 21, 2021 22:48
@ananthsub ananthsub merged commit f98cd78 into Lightning-AI:master Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change ready PRs ready to be merged refactor strategy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants