Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed the DDPSpawnPlugin to DDPSpawnStrategy #11145

Merged
merged 10 commits into from
Dec 21, 2021
Merged

Renamed the DDPSpawnPlugin to DDPSpawnStrategy #11145

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f292656
Rename DDPFullyShardedPlugin to DDPFullyShardedStrategy
four4fish Dec 17, 2021
d1d9e3d
Renamed the to
four4fish Dec 18, 2021
28663c1
update changelog
four4fish Dec 18, 2021
9114f39
Merge branch 'master' into rename/ddp_spawn
four4fish Dec 20, 2021
31625f7
Update tpu_spawn.py
four4fish Dec 20, 2021
987a260
Update tpu_spawn.py
four4fish Dec 20, 2021
67f2f4a
Apply suggestions from code review
four4fish Dec 20, 2021
5fc45ea
Merge branch 'master' into rename/ddp_spawn
four4fish Dec 21, 2021
66b4ed3
Update CHANGELOG.md
four4fish Dec 21, 2021
3b4a54e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytorch_lightning/plugins/training_type/tpu_spawn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ def should_rank_save_checkpoint(self) -> bool:
def register_plugins(cls, plugin_registry: Dict) -> None:
plugin_registry.register("tpu_spawn_debug", cls, description="TPUSpawn Plugin with `debug` as True", debug=True)

@TPUSpawnPlugin.checkpoint_io.setter
@DDPSpawnStrategy.checkpoint_io.setter
carmocca marked this conversation as resolved.
Show resolved Hide resolved
def checkpoint_io(self, io: Optional[XLACheckpointIO]) -> None:
if io is not None and not isinstance(io, XLACheckpointIO):
raise MisconfigurationException(f"{self.__class__.__name__}.checkpoint_io` must be a `XLACheckpointIO`.")
Expand Down