-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove redundant methods in RichProgressBar #11100
Conversation
for more information, see https://pre-commit.ci
This PR does not address the comment you are linking to. There must be a misunderstanding. Two scenarios:
Only one of the two applies, and given the existing code I suspect 2 is the case. |
OK, then what should I do in this PR |
I believe just removing this code: def __getstate__(self):
# can't pickle the rich progress objects
state = self.__dict__.copy()
state["progress"] = None
state["_console"] = None
return state
def __setstate__(self, state):
self.__dict__ = state
self._console = Console(**self._console_kwargs) |
@awaelchli removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
What does this PR do?
after #10896
_init_progress
should run in the spawned processes already. We can remove this setstate method entirely.see #10875 (comment)
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃