Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant methods in RichProgressBar #11100

Merged
merged 15 commits into from
Dec 17, 2021
Merged

remove redundant methods in RichProgressBar #11100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c379bed
to Optional[Dict[str, Any], Console]
quancs Dec 16, 2021
a1b0152
update
quancs Dec 16, 2021
b0b6a24
update
quancs Dec 16, 2021
37ecfd8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 16, 2021
5383066
fix
quancs Dec 16, 2021
1b4bea6
Merge branch 'patch-2' of https://github.com/quancs/pytorch-lightning…
quancs Dec 16, 2021
9e60208
Merge branch 'master' into patch-2
quancs Dec 16, 2021
d045e03
Revert "fix"
quancs Dec 17, 2021
39f2432
Revert "update"
quancs Dec 17, 2021
a9f2819
Revert "update"
quancs Dec 17, 2021
2390a6f
Revert "to Optional[Dict[str, Any], Console]"
quancs Dec 17, 2021
635cf35
apply reviews
quancs Dec 17, 2021
5df3d7d
update
quancs Dec 17, 2021
51c2888
Update pytorch_lightning/callbacks/progress/rich_progress.py
quancs Dec 17, 2021
375deae
Merge branch 'master' into patch-2
carmocca Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Removed duplicated file extension when uploading model checkpoints with `NeptuneLogger` ([#11015](https://github.com/PyTorchLightning/pytorch-lightning/pull/11015))


- Removed `__getstate__` and `__setstate__` of `RichProgressBar` ([#11100](https://github.com/PyTorchLightning/pytorch-lightning/pull/11100))


- The `DDPPlugin` and `DDPSpawnPlugin` and their subclasses now remove the `SyncBatchNorm` wrappers in `teardown()` to enable proper support at inference after fitting ([#11078](https://github.com/PyTorchLightning/pytorch-lightning/pull/11078))


Expand Down
11 changes: 0 additions & 11 deletions pytorch_lightning/callbacks/progress/rich_progress.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,17 +318,6 @@ def on_validation_start(self, trainer, pl_module):
super().on_validation_start(trainer, pl_module)
self._init_progress(trainer)

def __getstate__(self):
# can't pickle the rich progress objects
state = self.__dict__.copy()
state["progress"] = None
state["_console"] = None
return state

def __setstate__(self, state):
self.__dict__ = state
self._console = Console(**self._console_kwargs)

def on_sanity_check_start(self, trainer, pl_module):
super().on_sanity_check_start(trainer, pl_module)
self._init_progress(trainer)
Expand Down