Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix Flash Zero datamodule kwargs #994

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes #993

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #994 (07c0dc2) into master (504c4c2) will increase coverage by 3.39%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
+ Coverage   85.00%   88.40%   +3.39%     
==========================================
  Files         250      250              
  Lines       13190    13199       +9     
==========================================
+ Hits        11212    11668     +456     
+ Misses       1978     1531     -447     
Flag Coverage Δ
unittests 88.40% <91.66%> (+3.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/tabular/forecasting/cli.py 100.00% <ø> (ø)
flash/core/utilities/flash_cli.py 94.24% <91.66%> (-0.38%) ⬇️
flash/core/data/data_module.py 95.39% <0.00%> (+1.06%) ⬆️
flash/core/utilities/stages.py 78.26% <0.00%> (+4.34%) ⬆️
flash/text/seq2seq/translation/model.py 68.18% <0.00%> (+4.54%) ⬆️
flash/text/seq2seq/summarization/model.py 80.00% <0.00%> (+5.00%) ⬆️
flash/core/integrations/labelstudio/input.py 86.59% <0.00%> (+5.58%) ⬆️
flash/text/seq2seq/core/model.py 68.88% <0.00%> (+8.88%) ⬆️
flash/text/classification/model.py 91.83% <0.00%> (+14.28%) ⬆️
flash/text/question_answering/finetuning.py 23.52% <0.00%> (+19.60%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 504c4c2...07c0dc2. Read the comment docs.

@ethanwharris ethanwharris added the bug / fix Something isn't working label Nov 23, 2021
@ethanwharris ethanwharris merged commit 19cf911 into master Nov 23, 2021
@ethanwharris ethanwharris deleted the bugfix/datamodule_kwargs_zero branch November 23, 2021 21:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flash Zero does not recognize arguments hidden in kwargs
2 participants