Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Flash Zero does not recognize arguments hidden in kwargs #993

Closed
Borda opened this issue Nov 23, 2021 · 0 comments · Fixed by #994
Closed

Flash Zero does not recognize arguments hidden in kwargs #993

Borda opened this issue Nov 23, 2021 · 0 comments · Fixed by #994
Labels
bug / fix Something isn't working help wanted Extra attention is needed

Comments

@Borda
Copy link
Member

Borda commented Nov 23, 2021

🐛 Bug

if the from_csv has some inherited arguments such as batch_size it is not recognized...

To Reproduce

flash tabular_classification \
    --model.learning_rate=0.01 \
    --model.optimizer="AdamW" \
    --trainer.max_epochs 20 \
    --trainer.accumulate_grad_batches=12 \
    --trainer.gradient_clip_val=0.1 \
    from_csv \
    --train_file=/home/jirka/Downloads/train.csv \
    --numerical_fields=f0 \
    --target_fields="target" \
    --val_split=0.2 \
    --batch_size=512

fails with:

tabular_classification: error: Unrecognized arguments: --val_split=0.2 --batch_size=512

moreover seems as the kwargs are not exposed at all:

usage: tabular_classification [options] from_csv [-h] [--categorical_fields CATEGORICAL_FIELDS] [--numerical_fields NUMERICAL_FIELDS] [--target_fields TARGET_FIELDS]
                                                 [--parameters PARAMETERS] [--train_file TRAIN_FILE] [--val_file VAL_FILE] [--test_file TEST_FILE] [--predict_file PREDICT_FILE]
                                                 [--train_transform TRAIN_TRANSFORM] [--val_transform VAL_TRANSFORM] [--test_transform TEST_TRANSFORM]
                                                 [--predict_transform PREDICT_TRANSFORM]

Additional context

@Borda Borda added bug / fix Something isn't working help wanted Extra attention is needed labels Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant