This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Fixes wrong label in FilePathDataset #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of labels, file names were used for making label-to-class map.
ibraheemmmoosa
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
tchaton and
teddykoker
as code owners
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 86.63% 86.64%
=======================================
Files 45 45
Lines 1369 1370 +1
=======================================
+ Hits 1186 1187 +1
Misses 183 183
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Borda
reviewed
Feb 9, 2021
flash/vision/classification/data.py
Outdated
| @@ -56,7 +56,7 @@ def __init__( | |||
| self.transform = transform | |||
| self.loader = loader | |||
| if self.has_labels: | |||
| self.label_to_class_mapping = {v: k for k, v in enumerate(list(sorted(list(set(self.fnames)))))} | |||
| self.label_to_class_mapping = {v: k for k, v in enumerate(list(sorted(list(set(self.labels)))))} | |||
There was a problem hiding this comment.
Suggested change
| self.label_to_class_mapping = {v: k for k, v in enumerate(list(sorted(list(set(self.labels)))))} | |
| self.label_to_class_mapping = {v: k for k, v in enumerate(sorted(set(self.labels)))} |
maybe we can just zip
There was a problem hiding this comment.
I have updated the code. I think it now looks cleaner.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of labels, file names were used for making label-to-class map.
What does this PR do?
Fixes #93
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃