Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

FilePathDataset is giving wrong labels. #93

Closed
ibraheemmmoosa opened this issue Feb 9, 2021 · 0 comments · Fixed by #94
Closed

FilePathDataset is giving wrong labels. #93

ibraheemmmoosa opened this issue Feb 9, 2021 · 0 comments · Fixed by #94

Comments

@ibraheemmmoosa
Copy link
Contributor

https://github.com/PyTorchLightning/lightning-flash/blob/da6b6376dffe7e647782595f467450fbd9310f9d/flash/vision/classification/data.py#L68

The current implementation of FilepathDataset is giving wrong labels. It is creating a unique label for each file.
ibraheemmmoosa added a commit to ibraheemmmoosa/lightning-flash that referenced this issue Feb 9, 2021
@ibraheemmmoosa
Fixes Lightning-Universe#93
eade7cd 
Instead of labels, file names were used for making label-to-class map.
@Borda Borda mentioned this issue Feb 9, 2021
Merged
8 tasks
williamFalcon pushed a commit that referenced this issue Feb 9, 2021
@ibraheemmmoosa
Fixes wrong label in FilePathDataset (#94)
c79e403 
* Fixes #93

Instead of labels, file names were used for making label-to-class map.

* Fix label mapping in FilePathDataset __getitem__

* Cleanup label to class mapping code.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes wrong label in FilePathDataset ibraheemmmoosa/lightning-flash
1 participant
@ibraheemmmoosa