Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

VISSL initial integration #682

Merged
merged 68 commits into from
Sep 21, 2021
Merged

VISSL initial integration #682

merged 68 commits into from
Sep 21, 2021

Conversation

ananyahjha93
Copy link
Contributor

@ananyahjha93 ananyahjha93 commented Aug 20, 2021

What does this PR do?

POC PR for VISSL

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #682 (4f68899) into master (d963de7) will increase coverage by 0.54%.
The diff coverage is 80.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
+ Coverage   89.07%   89.62%   +0.54%     
==========================================
  Files         198      213      +15     
  Lines       10693    11317     +624     
==========================================
+ Hits         9525    10143     +618     
- Misses       1168     1174       +6     
Flag Coverage Δ
unittests 89.62% <80.18%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/audio/classification/cli.py 100.00% <ø> (ø)
flash/audio/speech_recognition/cli.py 100.00% <ø> (ø)
flash/graph/classification/cli.py 92.30% <ø> (+49.45%) ⬆️
flash/image/classification/cli.py 84.61% <ø> (-1.10%) ⬇️
flash/image/classification/data.py 94.11% <ø> (ø)
flash/image/detection/cli.py 100.00% <ø> (ø)
flash/image/detection/data.py 93.75% <ø> (ø)
...lash/image/embedding/vissl/transforms/multicrop.py 96.96% <ø> (ø)
flash/image/instance_segmentation/cli.py 100.00% <ø> (ø)
flash/image/instance_segmentation/data.py 88.23% <ø> (ø)
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d963de7...4f68899. Read the comment docs.

flash/core/integrations/vissl/adapter.py Outdated Show resolved Hide resolved
flash/core/integrations/vissl/adapter.py Outdated Show resolved Hide resolved
flash/core/integrations/vissl/adapter.py Outdated Show resolved Hide resolved
flash/core/integrations/vissl/adapter.py Outdated Show resolved Hide resolved
flash/core/integrations/vissl/adapter.py Outdated Show resolved Hide resolved
flash/core/integrations/vissl/base_ssl_model.py Outdated Show resolved Hide resolved
flash/core/integrations/vissl/base_ssl_model.py Outdated Show resolved Hide resolved
flash/core/integrations/vissl/dino_hook.py Outdated Show resolved Hide resolved
@ethanwharris ethanwharris mentioned this pull request Sep 11, 2021
8 tasks
@ethanwharris ethanwharris changed the base branch from master to active_learning September 21, 2021 17:17
@ethanwharris ethanwharris changed the base branch from active_learning to master September 21, 2021 17:17
@mergify mergify bot removed the has conflicts label Sep 21, 2021
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Docs, docstrings etc. to come in follow-up 😃

@ananyahjha93
Copy link
Contributor Author

@ethanwharris The image classification notebook is failing when loading the checkpoint from s3.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work ! Definitely looks much better now :) Still some comment, but can be addressed in the following PR.

flash/core/registry.py Show resolved Hide resolved
qk_scale: bool = False,
classifier: str = "token",
**kwargs,
) -> nn.Module:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some docstrings would be good. Same below.

flash/image/embedding/heads/vissl_heads.py Show resolved Hide resolved
flash/image/embedding/vissl/adapter.py Show resolved Hide resolved
flash/image/embedding/vissl/adapter.py Show resolved Hide resolved
flash/image/embedding/vissl/adapter.py Show resolved Hide resolved
flash/image/embedding/vissl/hooks.py Show resolved Hide resolved
flash_examples/image_embedder.py Show resolved Hide resolved
@tchaton tchaton merged commit d190c76 into master Sep 21, 2021
@tchaton tchaton deleted the feature/vissl branch September 21, 2021 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants