-
Notifications
You must be signed in to change notification settings - Fork 212
Conversation
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
==========================================
+ Coverage 89.07% 89.62% +0.54%
==========================================
Files 198 213 +15
Lines 10693 11317 +624
==========================================
+ Hits 9525 10143 +618
- Misses 1168 1174 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
c0803c5
to
603b421
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Docs, docstrings etc. to come in follow-up 😃
@ethanwharris The image classification notebook is failing when loading the checkpoint from s3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work ! Definitely looks much better now :) Still some comment, but can be addressed in the following PR.
qk_scale: bool = False, | ||
classifier: str = "token", | ||
**kwargs, | ||
) -> nn.Module: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some docstrings would be good. Same below.
What does this PR do?
POC PR for VISSL
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃