Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

[WIP] Training Strategies #571

Closed
wants to merge 12 commits into from
Closed

[WIP] Training Strategies #571

wants to merge 12 commits into from

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #571 (001957f) into master (08b56dd) will decrease coverage by 7.52%.
The diff coverage is 87.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
- Coverage   89.98%   82.46%   -7.53%     
==========================================
  Files         149      151       +2     
  Lines        8457     8484      +27     
==========================================
- Hits         7610     6996     -614     
- Misses        847     1488     +641     
Flag Coverage Δ
unittests 82.46% <87.80%> (-7.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/classification/strategy/supervised.py 86.20% <86.20%> (ø)
flash/image/classification/model.py 79.16% <87.50%> (+0.32%) ⬆️
flash/core/registry.py 94.82% <100.00%> (-1.73%) ⬇️
flash/image/classification/strategy/__init__.py 100.00% <100.00%> (ø)
flash/image/detection/data.py 31.29% <0.00%> (-64.13%) ⬇️
flash/image/detection/serialization.py 30.76% <0.00%> (-63.47%) ⬇️
flash/audio/speech_recognition/collate.py 51.61% <0.00%> (-48.39%) ⬇️
flash/image/classification/data.py 46.05% <0.00%> (-48.03%) ⬇️
flash/audio/speech_recognition/backbone.py 55.55% <0.00%> (-44.45%) ⬇️
flash/image/segmentation/data.py 47.84% <0.00%> (-42.11%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b56dd...001957f. Read the comment docs.

@ananyahjha93 ananyahjha93 requested review from ananyahjha93 and removed request for ananyahjha93 July 13, 2021 19:40
@ethanwharris
Copy link
Collaborator Author

Being addressed in #682 and #737

@Borda Borda deleted the feature/strategies branch April 27, 2022 14:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants