-
Notifications
You must be signed in to change notification settings - Fork 212
Added field parameter to the from_json method with other required cha… #585
Added field parameter to the from_json method with other required cha… #585
Conversation
Codecov Report
@@ Coverage Diff @@
## master #585 +/- ##
==========================================
+ Coverage 81.19% 90.55% +9.35%
==========================================
Files 32 132 +100
Lines 1037 7782 +6745
==========================================
+ Hits 842 7047 +6205
- Misses 195 735 +540
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…_tasks_for_json_datasets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, LGTM 😃 Mind also updating CHANGELOG.md
?
I have updated the PR with both the changes. |
…_tasks_for_json_datasets
…_tasks_for_json_datasets
…nges.
What does this PR do?
Fixes #576
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃