Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Conversation

karthikrangasai
Copy link
Contributor

@karthikrangasai karthikrangasai commented Jul 14, 2021

…nges.

What does this PR do?

Fixes #576

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #585 (9ffc2a0) into master (008bc75) will increase coverage by 9.35%.
The diff coverage is 93.43%.

❗ Current head 9ffc2a0 differs from pull request most recent head 1fdf594. Consider uploading reports for the commit 1fdf594 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
+ Coverage   81.19%   90.55%   +9.35%     
==========================================
  Files          32      132     +100     
  Lines        1037     7782    +6745     
==========================================
+ Hits          842     7047    +6205     
- Misses        195      735     +540     
Flag Coverage Δ
unittests 90.55% <93.43%> (+9.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/classification/data.py 89.47% <ø> (ø)
flash/image/classification/model.py 78.84% <ø> (ø)
flash/image/classification/transforms.py 90.47% <ø> (ø)
flash/image/data.py 100.00% <ø> (ø)
flash/image/detection/__init__.py 100.00% <ø> (ø)
flash/image/detection/data.py 95.41% <ø> (ø)
flash/image/detection/finetuning.py 100.00% <ø> (ø)
flash/image/detection/model.py 83.11% <ø> (ø)
flash/image/detection/serialization.py 94.23% <ø> (ø)
flash/image/detection/transforms.py 100.00% <ø> (ø)
... and 247 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6e0d20...1fdf594. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM 😃 Mind also updating CHANGELOG.md?

flash/core/data/data_module.py Outdated Show resolved Hide resolved
@karthikrangasai
Copy link
Contributor Author

I have updated the PR with both the changes.

@mergify mergify bot removed the has conflicts label Jul 14, 2021
@mergify mergify bot removed the has conflicts label Jul 14, 2021
@ethanwharris ethanwharris merged commit 87df19a into Lightning-Universe:master Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose the field parameter for JSON data sources in Seq2Seq tasks
2 participants